On Wed, Aug 17, 2016 at 10:43:27AM -0400, Adam Jackson wrote: > Before 5c69cb60 this wouldn't matter, because ProcXIQueryPointer > manually emitted its own error before (bogusly) returning Success to the > main loop. Since these tests only look at the return value of the > dispatch function we'd think things succeeded even when we'd generated > an error. > > With that fixed, the test code's failure to swap the window id would > make dixLookupWindow (rightly) throw BadWindow. > > Signed-off-by: Adam Jackson <[email protected]>
woops, sorry. Reviewed-by: Peter Hutterer <[email protected]> Cheers, Peter > --- > test/xi2/protocol-xiquerypointer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/test/xi2/protocol-xiquerypointer.c > b/test/xi2/protocol-xiquerypointer.c > index c0421f6..2bf18fa 100644 > --- a/test/xi2/protocol-xiquerypointer.c > +++ b/test/xi2/protocol-xiquerypointer.c > @@ -140,6 +140,7 @@ request_XIQueryPointer(ClientPtr client, > xXIQueryPointerReq * req, int error) > > client_request.swapped = TRUE; > swaps(&req->deviceid); > + swapl(&req->win); > swaps(&req->length); > rc = SProcXIQueryPointer(&client_request); > assert(rc == error); > -- > 2.7.4 > _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
