On 08/16/2016 02:10 AM, Hans de Goede wrote: > The "if (pixmap) ..." block this commit removes is inside an > "if (pixmap == NULL) ..." block, so it will never execute. > > Signed-off-by: Hans de Goede <[email protected]> > --- > hw/xfree86/drivers/modesetting/dri2.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/xfree86/drivers/modesetting/dri2.c > b/hw/xfree86/drivers/modesetting/dri2.c > index b810d59..9bc56c2 100644 > --- a/hw/xfree86/drivers/modesetting/dri2.c > +++ b/hw/xfree86/drivers/modesetting/dri2.c > @@ -186,8 +186,6 @@ ms_dri2_create_buffer(DrawablePtr drawable, unsigned int > attachment, > pixmap_cpp, > 0); > if (pixmap == NULL) { > - if (pixmap) > - screen->DestroyPixmap(pixmap); > free(private); > free(buffer); > return NULL; >
Well this one is certainly obvious. Reviewed-by: Aaron Plattner <[email protected]> _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
