On Fri, Jul 1, 2016 at 15:44:41 +0100, Emil Velikov wrote: > Hi all, > > A series that I've had around for long time. It covers three main topics. > - misc cleanups and small reformatting in prep. for mesa support > - mesa support (10/10) > - give us control to autoreconf, configure and build_dir (09/10). > > The last option might be a bit controversial, yet it effectively allows > us to remove the "user must run autoreconf/configure" requirement > from every single package. If configure is OK, `make distcheck' should > produce consistent result, and the tarball contents should not vary. > > It also minimises the chances of stale (generated) files being used as > we suggest git clean -fXd/fxd, and we use fresh, unique build_dir. IMHO > it also makes things more reproducible, yet again... I'm too flesh on > the topic to be an expert. > > As always, any and all comments, suggestions are appreciated. > For 1, 3, 4, 5, 7 (assuming 10 goes in in some way): Reviewed-by: Julien Cristau <[email protected]>
Not a fan of 2 and 6. I don't have enough context to understand what 8 changes. 9 seems to add a new requirement that I'm not sure is ok. And I wish mesa stopped using a separate directory per release :) Cheers, Julien _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
