On 05/10/16 07:05 PM, Hans de Goede wrote: > On 05-10-16 11:45, Hans de Goede wrote: >> On 05-10-16 11:41, Michel Dänzer wrote: >>> From: Michel Dänzer <[email protected]> >>> >>> I wanted to enable HW cursors on PRIME slave screens in our drivers, but >>> noticed that a few things aren't quite right yet. >>> >>> The series is ordered from the most obvious problem to more subtle ones. >>> Patches 1 & 2 fix incorrect positioning of the HW cursor on PRIME slave >>> screens. Patch 3 fixes a subtle issue which I noticed while debugging >>> the PRIME slave screen issues, but which affects non-PRIME screens as >>> well. >> >> Thank you for catching this. All 3 patches look good to me and are: >> >> Reviewed-by: Hans de Goede <[email protected]> > > Scrap that, this needs a v2, while debugging another issue with these > 3 patches added to my local tree I'm get segfaults because > pCurs->bits can be NULL in at least xf86SetCursor and we end up > dereferencing a NULL pointer.
Ah, that's what that was. :) I saw crashes on server shutdown, but seemed to remember reading about random input thread related crashes somewhere, so I thought it was those and postponed looking into them. I'll send a v2 series, thanks for the review and testing. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
