On 10/10/2016 19:31, Mihail Konev wrote:
Hello.

On Mon Oct 10 14:59:52 UTC 2016, Jon Turney wrote:
@@ -16,11 +20,10 @@ AM_CPPFLAGS = \
        -I$(top_srcdir)/hw/xfree86/os-support/bus \
        -I$(top_srcdir)/hw/xfree86/common \
        -I$(top_srcdir)/hw/xfree86/dri \
+       -I$(top_srcdir)/hw/xfree86/dri2
        -I$(top_srcdir)/mi \
        -I$(top_srcdir)/present

Shouldn't there be a backslash?

Absolutely!  Revised patch attached.

I build-tested this on linux with --enable-dri2 and --disabl-dri2

From 549d3d4b82009319563c42b3d0113361ded257aa Mon Sep 17 00:00:00 2001
From: Jon Turney <[email protected]>
Date: Thu, 6 Oct 2016 22:13:07 +0100
Subject: [PATCH xserver] glx/dri2: Don't build DRI loader if DRI2 isn't
 enabled

This partially reverts 501d8e2b.

Signed-off-by: Jon Turney <[email protected]>
---
 glx/Makefile.am                | 11 ++++++++---
 hw/xfree86/dixmods/Makefile.am |  2 ++
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/glx/Makefile.am b/glx/Makefile.am
index fc0b76a..699de63 100644
--- a/glx/Makefile.am
+++ b/glx/Makefile.am
@@ -1,4 +1,8 @@
-noinst_LTLIBRARIES = libglx.la libglxdri.la
+if DRI2
+GLXDRI_LIBRARY = libglxdri.la
+endif
+
+noinst_LTLIBRARIES = libglx.la $(GLXDRI_LIBRARY)
 
 AM_CFLAGS = \
        @DIX_CFLAGS@ \
@@ -16,11 +20,10 @@ AM_CPPFLAGS = \
        -I$(top_srcdir)/hw/xfree86/os-support/bus \
        -I$(top_srcdir)/hw/xfree86/common \
        -I$(top_srcdir)/hw/xfree86/dri \
+       -I$(top_srcdir)/hw/xfree86/dri2 \
        -I$(top_srcdir)/mi \
        -I$(top_srcdir)/present
 
-AM_CPPFLAGS += -I$(top_srcdir)/hw/xfree86/dri2
-
 indirect_sources =                             \
        indirect_dispatch.c                     \
        indirect_dispatch.h                     \
@@ -33,7 +36,9 @@ indirect_sources =                            \
        indirect_table.c
 
 libglxdri_la_SOURCES =
+if DRI2
 libglxdri_la_SOURCES += glxdri2.c
+endif
 
 libglxdri_la_LIBADD = $(DLOPEN_LIBS)
 
diff --git a/hw/xfree86/dixmods/Makefile.am b/hw/xfree86/dixmods/Makefile.am
index be43e8f..d534c78 100644
--- a/hw/xfree86/dixmods/Makefile.am
+++ b/hw/xfree86/dixmods/Makefile.am
@@ -29,10 +29,12 @@ libwfb_la_CFLAGS = $(AM_CFLAGS) -DFB_ACCESS_WRAPPER
 
 libglx_la_LDFLAGS = -module -avoid-version $(LD_NO_UNDEFINED_FLAG)
 libglx_la_LIBADD = $(top_builddir)/glx/libglx.la $(GLX_SYS_LIBS)
+if DRI2
 libglx_la_LIBADD += $(top_builddir)/glx/libglxdri.la
 if NO_UNDEFINED
 libglx_la_LIBADD += $(LIBDRM_LIBS) $(PIXMAN_LIBS)
 endif
+endif
 libglx_la_SOURCES = glxmodule.c
 
 libshadow_la_LDFLAGS = -module -avoid-version $(LD_NO_UNDEFINED_FLAG)
-- 
2.8.3

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to