On 27/10/16 21:03, Eric Anholt wrote:
Martin Peres <[email protected]> writes:

On 21/10/16 19:18, Eric Anholt wrote:
Martin Peres <[email protected]> writes:

This allows a runner such as EzBench to track each test individually
and not limit the resolution to groups.

This feature can be triggered by using the -r parameter.

I don't really see the point of this -- you need an external runner to
be choosing a specific test subset to run per rendercheck call, since
the full matrix of composite tests is too long.  Once you have an
external runner calling rendercheck per test group, all you would be
able to do using this patch would be save a few spawns of the process,
which doesn't seem worth it.

Just to be sure, are you suggesting I do something like this instead?

for format in "a8r8g8b8 x8r8g8b8 ... more formats"; do
        ./rendercheck -f $format
        # parse the successful groups and store them, prefixed by $format so as
I can identify regressions per format?
done

You should probably look at piglit for subsetting of the tests.
Actually, I'd say you should probably just use piglit.  Given that
piglit is what X developers are going to be using, if we're going to
lock rendercheck into specific output formats I'd like to see the piglit
patches included with it.

That would be reasonable :) I will look into this.

Martin
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to