On Sat, Feb 18, 2017 at 01:24:19PM +0500, Mihail Konev wrote:
> On Mon, Feb 13, 2017 at 11:01:39PM -0800, Alan Coopersmith wrote:
> > > On 02/ 9/17 09:47 PM, Mihail Konev wrote:
> > >> Libtool was moving the *.O libraries in front of all others on
> > >> the gcc command line, which was necessiating "ld -r"
> > >> (so that symbols from now-moved os.O are visible from the following
> > >> libs), which, in turn, was altering the linker behaviour against os/
> > >> and dix/ between with-/usr/bin/dtrace and --with-dtrace=no builds.
> > 
> > ld -r was used not because of libtool, but because the dtrace data in the
> > ELF files gets properly included in a relocatable object, but not a static
> > library.  (This is probably because of a misuse of ELF by dtrace, but that's
> > the way it works, and has for over a decade.)
> > 
> 
> Then rather than "Fixes:", it should be
> 
>   Updates: 49a26681 ("Add DTrace probe points")
> 

Sorry, the patch had no mistake there.
Instead, looking at the message, but not the build logs, I only recalled
the ar-is-insufficient issue, and not the libos-is-ar-ed one.

> 
> Mihail

Mihail
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to