On 07/03/17 03:02 AM, Eric Anholt wrote: > Michel Dänzer <[email protected]> writes: > >> From: Michel Dänzer <[email protected]> >> >> Or if the cache watermark is reached, whichever comes earlier. >> >> This slightly simplifies the FBO cache management, and prevents it from >> potentially holding entries for a long time, while preserving the main >> benefit of the cache for bursts of drawing operations. >> >> Signed-off-by: Michel Dänzer <[email protected]> > > For re-adding an FBO cache, I would need to see that we have > APPLE_object_purgeable used so that the FBO cache can be evicted, and > use proper timers to garbage collect the FBOs instead of waiting for N > blockhandlers, which is only vaguely related to wall time.
Right, I already came to the conclusion that a time based expiry mechanism would be needed (limiting until the next BlockHandler as in patch 2 actually seems too restrictive and still results in some minor regressions). I'll play around some more to see if we can make do without the glamor FBO cache, and take your feedback and Max's into account otherwise, thanks. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
