On 08/05/2017 18:12, Eric Anholt wrote:
Jon Turney writes:
+libxserver_dri3 = ''
Pretty sure this should be = []
Yeah, me too. But when I try it:
Meson encountered an error in file hw/kdrive/ephyr/meson.build, line 40, column
0:
Link target [] is not library.
Hmmm.. if I add it with libxserver += libxserver_dri3, it works, so it
seems there is some kind of list flattening failure somewhere...
+libdrm_required = (get_option('dri1') == 'yes') or (get_option('dri2') ==
'yes') or (get_option('dri3') == 'yes')
+libdrm_dep = dependency('libdrm', version: '>= 2.3.1', required:
libdrm_required)
+build_modesetting = false
+if libdrm_dep.found()
+ if build_dri2
+ # 2.4.65 is required for drmGetDevice
+ dependency('libdrm', version: '>= 2.4.65')
+ endif
+ # 2.4.46 is required for cursor hotspot support.
+ build_modesetting = dependency('libdrm', version: '>= 2.4.46', required:
false).found()
+endif
I think this is more clearly stated as:
build_modesetting = libdrm_dep.version().version_compare('>= 2.4.46')
Yes, much better.
It's a bit of an odd choice (modesetting driver if you have dri1/2/3
enabled, or if libdrm happened to be found anyway), but that should be
true so often I don't think it's worth worrying about.
Yeah, it seems a bit strange to me that there is no explicit
--enable-modesetting-driver in configure.ac
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
