On 07/06/17 01:59 AM, Keith Packard wrote: > Michel Dänzer <[email protected]> writes: > >> From: Michel Dänzer <[email protected]> >> >> Fixes crash with xli. No regressions with xterm, x11perf -copyplane or >> the xscreensaver phosphor hack. > > Do you have any more details to share? I'm willing to review, but > figuring out why you think this is a good idea would be really > helpful...
Mostly the fact that without this patch, the crash from https://bugs.debian.org/857983 is easily reproducible with pgmnoise 2040 4752 | pgmtopbm | xli stdin whereas with the patch it's not. :) (Apparently a similar crash can happen with the xscreensaver halo hack; I haven't been able to reproduce that, but assume it's fixed by this patch as well) Presumably this wasn't hit before because the code before and after this change is equivalent in some (most?) cases. xli seems to handle scrolling by moving a larger child window inside a smaller parent window, in which case it's not equivalent. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer
signature.asc
Description: OpenPGP digital signature
_______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
