On 03/08/17 01:19 PM, Keith Packard wrote:
> Michel Dänzer <[email protected]> writes:
> 
>> Shouldn't this be done at a higher level instead?
> 
> Thanks for a really good question.
> 
> The X server doesn't touch cursors when turning off crtcs that aren't in
> use any more. That's because xf86DisableUnusedFunctions doesn't touch
> the cursor for disabled crtcs, it only sets the cursor for enabled ones.
> 
> I think a better patch is to just disable the cursor whenever we're
> turning the crtc off during mode setting. After the mode setting is
> finished, xf86DisableUnusedFunctions will get called and that will call
> xf86CursorResetCursor to make sure the cursor is enabled everywhere it
> should be.
> 
> Here's a replacement for the modesetting patch which does this up in
> xfree86/modes:

Looks good to me.

Reviewed-by: Michel Dänzer <[email protected]>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to