On 05/09/17 02:52 AM, Emil Velikov wrote: > From: Emil Velikov <[email protected]> > > Namely: sync_flip has been unused since the code was introduced back in > 2015. > > Cc: Kenneth Graunke <[email protected]> > Cc: Dave Airlie <[email protected]> > Signed-off-by: Emil Velikov <[email protected]> > --- > Hi all, > I'm fairly certain that the original goal was to actually check the > boolean. Yet I'm not that familiar with the code to be the final > judge of that, hence sending this as an RFC. > > Not to mention that this is an ABI break ;-)
Indeed, and the sync_flip parameter is used by the xf86-video-intel SNA driver. In general, it's not hard to imagine that a driver's return value for this hook could depend on the sync_flip value, so I don't think this is a good idea. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
