On Sun, 2017-11-12 at 17:02 -0800, Keith Packard wrote: > Adam Jackson <[email protected]> writes: > > > + /* > > + * Not a simple Unwrap/Wrap as this isn't called along the > > DisplayCursor > > + * wrapper chain. > > + */ > > + pScreen->DisplayCursor = as->DisplayCursor; > > + (void) (*pScreen->DisplayCursor) (dev, pScreen, ac->elts[elt].pCursor); > > + as->DisplayCursor = pScreen->DisplayCursor; > > + pScreen->DisplayCursor = DisplayCursor; > > I'm probably reading this out of context, but if this isn't called along > the usual DisplayCursor wrapper chain, then it's presumptuous to smash > in our DisplayCursor pointer; shouldn't it preserve the previous value > and restore that instead?
You added that comment when you added XFIXES to XFree86, presumably you know what it means better than I do. - ajax _______________________________________________ [email protected]: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
