On 18/01/2018 21:27, Adam Jackson wrote:
On Wed, 2018-01-17 at 19:02 +0000, Jon Turney wrote:
On 08/01/2018 20:50, Adam Jackson wrote:
---
   include/meson.build | 1 +
   meson_options.txt   | 1 +
   os/meson.build      | 4 ++++
   3 files changed, 6 insertions(+)

After this, I needed something like the attached.

Eep, indeed you would. But I think we should actually prefer tirpc if
it's available, glibc's rpc code has been deprecated for years and I
believe the next Fedora release is going to try removing the headers
for it again.

I guess XTRANS_SECURE_RPC_FLAGS will also need adjusting to express that preference

Is the extra-underscore thing really necessary? I'd have hoped meson
would take care of that.

This is not due to leading-underscore ABI issues, it's due to me looking at the following in os/rpcauth.c:

#ifdef SVR4
    if ((why = __authenticate(&r, &msg)) != AUTH_OK) {
#else
    if ((why = _authenticate(&r, &msg)) != AUTH_OK) {
#endif

I've no idea if that's legitimate or not :)

(This is the function that os/rpcauth.c actually uses, as opposed to the function(s) that XTRANS_SECURE_RPC_FLAGS check for)

I'll see if I can revise this patch to prefer tirpc.
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to