On 02/07/2018 03:18 PM, Mario Kleiner wrote:
On 02/06/2018 08:04 PM, Adam Jackson wrote:
On Mon, 2018-02-05 at 11:25 +0100, Thomas Hellstrom wrote:
On 02/05/2018 11:20 AM, Mario Kleiner wrote:
Commit 91c42093b248 ("glx: Duplicate relevant fbconfigs for
compositing visuals") adds many new depth 32 fbconfigs as
composite visuals. On a X-Screen running at depth 24, this
also adds bgra 10-10-10-2 fbconigs, as they also have
config.rgbBits == 32, but these are not displayable on a
depth 24 screen, leading to visually corrupted desktops
under some compositors, e.g., fdo bug 104597 "Compton
weird colors" when running compton with
"compton --backend glx".

Be more conservative for now and only select fbconfigs with
8 bpc red, green, blue components for composite visuals.

Fixes: 91c42093b248 ("glx: Duplicate relevant fbconfigs for
                        compositing visuals")
Bugzilla: https://urldefense.proofpoint.com/v2/url?u=https-3A__bugs.freedesktop.org_show-5Fbug.cgi-3Fid-3D104597&d=DwIBAg&c=uilaK90D4TOVoH58JNXRgQ&r=wnSlgOCqfpNS4d02vP68_E9q2BNMCwfD2OZ_6dCFVQQ&m=IbtkCrmjzJVhB0PdaE0y9A3Zqx2CEYhUPvtI6PeGSEo&s=6MOlztrQC3tRtcJvqesPVJ1ri_ILRWLMh-iZbrs7NJ0&e=
Signed-off-by: Mario Kleiner <mario.kleiner...@gmail.com>
Cc: Thomas Hellstrom <thellst...@vmware.com>
Cc: Adam Jackson <a...@redhat.com>

Reviewed-by: Thomas Hellstrom <thellst...@vmware.com>

remote: I: patch #202588 updated using rev bebcc8477c8070ade9dd4be7299c718baeab3d7a.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/xserver
    98edb9a35e..bebcc8477c  master -> master

- ajax


Thanks for the review and merge. This also needs to get picked into the server 1.19 branch. Are there plans to tag a new 1.19.7 release soon? I'm worried that if spring distro updates like Ubuntu 18.04 LTS would ship with Mesa 18.0 + server 1.19.6, instead of a 1.19.7 with these fixes, the 10 bpc related issues and the new sRGB Intel DRI stuff could cause quite a bit of pain for distro users without the fixes in the 1.19 branch, e.g., disappering menus in firefox and GNU/Octave under desktop composition, depending on the ddx in use and the phase of the moon.

thanks,
-mario

Hi,

I'm not sure the duplicating 91c420 commit actually got backported to 1.19? If not, that commit needs backporting as well as its fixes.

/Thomas


_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to