On Wed, 2018-04-04 at 16:16 +0100, Daniel Stone wrote: > Hi, > This series fixes running a modifier-aware server with a > non-modifier-aware DRI3 compositing manager. We'd thought of and dealt > with the case where we had legacy/non-modifier-aware clients, but > slipped up with non-modifier-aware compositing managers. > > Glamor would allocate pixmaps with the full set of modifiers available > to it from GBM/EGL, then try to export them to a non-modifier-aware > client. This may fail outright (e.g. when the modifier adds a plane), or > result in garbage (with an exotic modifier selection the client can't > infer via magic back channels). > > When we get a request to export a buffer to a non-modifier-aware client > in Glamor, forcibly reallocate it with no explicit modifiers, so we get > something that can be exported to legacy clients.
Took me a second to figure out how 5/7 was getting the reallocation to happen, but this all makes sense. It also fixes Xorg on my laptop, so thank you very much! Merged: remote: E: failed to find patch for rev 75bba3aedcb04132a4fe2806680cd38a8f2bd206. remote: I: patch #214874 updated using rev 0e9504e10c4363e24a83f1a82e6a4b9f5fd8f846. remote: I: patch #214875 updated using rev 1b9fa3b64ca420eb54b5e5f28074c326e1fbe825. remote: I: patch #214873 updated using rev aab5c46ccbe769830cae383330fd62c074a0d2f7. remote: I: patch #214879 updated using rev 86b2d8740a330deafe8a9bbf0402705a43efbb42. remote: I: patch #214877 updated using rev 9c407f0a1b40128fc65b19b6a499f1d4dae6f702. remote: I: patch #214878 updated using rev 23c67987a337beb91292f8e318d566941453baa3. remote: I: 6 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/xorg/xserver 574069c291..23c67987a3 master -> master - ajax _______________________________________________ email@example.com: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel