On 2018-04-05 05:47 PM, Daniel Stone wrote:
> We would fail to get the FB ID if it wasn't already imported, since we
> were checking to see if the pointer was NULL (it never was) rather than
> if the content of the pointer was 0.
>
> Signed-off-by: Daniel Stone <dani...@collabora.com>
> Reported-by: Olivier Fourdan <ofour...@redhat.com>
> ---
> hw/xfree86/drivers/modesetting/drmmode_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c
> b/hw/xfree86/drivers/modesetting/drmmode_display.c
> index cdcd4f3f3..322ef050b 100644
> --- a/hw/xfree86/drivers/modesetting/drmmode_display.c
> +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
> @@ -624,7 +624,7 @@ drmmode_crtc_get_fb_id(xf86CrtcPtr crtc, uint32_t *fb_id,
> int *x, int *y)
> *y = crtc->y;
> }
>
> - if (fb_id == 0) {
> + if (*fb_id == 0) {
> ret = drmmode_bo_import(drmmode, &drmmode->front_bo,
> &drmmode->fb_id);
> if (ret < 0) {
>
Reviewed-and-Tested-by: Michel Dänzer <michel.daen...@amd.com>
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
