Hi, The recent issue with Present due to the wrong pixmap size being given to xwl_glamor_pixmap_get_wl_buffer() got me thinking.
Considering that the code always use the drawable size now, that passing a wrong size is error prone because once the buffer is created for the given pixmap, subsequent calls to xwl_glamor_pixmap_get_wl_buffer() will always return that same buffer with GBM backend and considering EGLStream has no use for the given size either, there is really no point in passing the width/height in the API... The second patch was suggested by Emil, both GBM and EGLStream backends implement init_wl_registry() and has_wl_interfaces() so there is no point in marking those as optional. Those patches go on top and complement the previous series, i.e.: https://patchwork.freedesktop.org/series/44302/ https://patchwork.freedesktop.org/series/44303/ https://patchwork.freedesktop.org/series/44423/ https://patchwork.freedesktop.org/series/44489/ I realize this is becoming a bit hard to follow, so I've put then entire series here: git://people.freedesktop.org/~ofourdan/xserver xwayland https://cgit.freedesktop.org/~ofourdan/xserver/log/?h=xwayland So it's easier to review/test. Thanks! Olivier Olivier Fourdan (2): xwayland: simplify xwl_glamor_pixmap_get_wl_buffer() xwayland: mandatory EGL backend API hw/xwayland/xwayland-glamor-eglstream.c | 2 -- hw/xwayland/xwayland-glamor-gbm.c | 4 ++-- hw/xwayland/xwayland-glamor.c | 14 ++------------ hw/xwayland/xwayland-present.c | 5 +---- hw/xwayland/xwayland.c | 2 -- hw/xwayland/xwayland.h | 10 ++-------- 6 files changed, 7 insertions(+), 30 deletions(-) -- 2.17.1 _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
