Reviewed-by: Lyude Paul <ly...@redhat.com>
On Fri, 2018-06-15 at 08:57 +0200, Olivier Fourdan wrote: > drmmode_shadow_allocate() still uses drmModeAddFB() which may fail if > the format is not as expected, preventing from using a rotated output. > > Change it to use the new function drmmode_bo_import() which takes care > of calling the drmModeAddFB2() API. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106715 > Signed-off-by: Olivier Fourdan <ofour...@redhat.com> > --- > hw/xfree86/drivers/modesetting/drmmode_display.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/xfree86/drivers/modesetting/drmmode_display.c > b/hw/xfree86/drivers/modesetting/drmmode_display.c > index 859a21a9d..ec11b3f56 100644 > --- a/hw/xfree86/drivers/modesetting/drmmode_display.c > +++ b/hw/xfree86/drivers/modesetting/drmmode_display.c > @@ -1794,11 +1794,8 @@ drmmode_shadow_allocate(xf86CrtcPtr crtc, int width, > int height) > return NULL; > } > > - ret = drmModeAddFB(drmmode->fd, width, height, crtc->scrn->depth, > - drmmode->kbpp, > - drmmode_bo_get_pitch(&drmmode_crtc->rotate_bo), > - drmmode_bo_get_handle(&drmmode_crtc->rotate_bo), > - &drmmode_crtc->rotate_fb_id); > + ret = drmmode_bo_import(drmmode, &drmmode_crtc->rotate_bo, > + &drmmode_crtc->rotate_fb_id); > > if (ret) { > ErrorF("failed to add rotate fb\n"); -- Cheers, Lyude Paul _______________________________________________ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel
