On Tue, Jul 31, 2018 at 05:48:54PM +0200, Walter Harms wrote:
> 
> 
> > Peter Hutterer <peter.hutte...@who-t.net> hat am 31. Juli 2018 um 03:53
> > geschrieben:
> > 
> > 
> > /usr/include/features.h:184:3: warning: #warning "_BSD_SOURCE and 
> > _SVID_SOURCE
> > are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
> >  # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use 
> > _DEFAULT_SOURCE"
> 
> 
> Why is is needed in the first place ? (what would break if not set ?)

*shrug*

I honestly don't know and it builds fine here without it. But that doesn't
mean it will anywhere else and for something as rapidly changing as
fonttosfnt it's safer to just leave things be. It might take us another 9
years to release another bugfix release.

Cheers,
   Peter

> > Signed-off-by: Peter Hutterer <peter.hutte...@who-t.net>
> > ---
> >  Makefile.am | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/Makefile.am b/Makefile.am
> > index 6ce70b7..29169b1 100644
> > --- a/Makefile.am
> > +++ b/Makefile.am
> > @@ -22,7 +22,7 @@
> >  SUBDIRS = man
> >  bin_PROGRAMS = fonttosfnt
> >  
> > -AM_CFLAGS = -DXVENDORNAME=\"X.Org\ Foundation\" $(FONTTOSFNT_CFLAGS)
> > -DXVENDORNAMESHORT=\"X.Org\" -D_BSD_SOURCE -D_GNU_SOURCE $(CWARNFLAGS)
> > +AM_CFLAGS = -DXVENDORNAME=\"X.Org\ Foundation\" $(FONTTOSFNT_CFLAGS)
> > -DXVENDORNAMESHORT=\"X.Org\" -D_DEFAULT_SOURCE -D_GNU_SOURCE $(CWARNFLAGS)
> >  fonttosfnt_LDADD = $(FONTTOSFNT_LIBS) -lm
> >  
> >  fonttosfnt_SOURCES =       \
> > -- 
> > 2.17.1
> > 
> > _______________________________________________
> > xorg-devel@lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: https://lists.x.org/mailman/listinfo/xorg-devel
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Reply via email to