http://bugs.freedesktop.org/show_bug.cgi?id=14826
Summary: [patch] invalid check of return value of
xf86SetOperatingState
Product: xorg
Version: unspecified
Platform: Other
OS/Version: All
Status: NEW
Severity: critical
Priority: high
Component: Driver/Radeon
AssignedTo: [email protected]
ReportedBy: [EMAIL PROTECTED]
QAContact: [EMAIL PROTECTED]
Created an attachment (id=14851)
--> (http://bugs.freedesktop.org/attachment.cgi?id=14851)
fix invalid return value check of xf86SetOperatingState
In xf86-video-ati/src/radeon_driver.c this check appears to always fail:
if (xf86SetOperatingState(resVga, info->pEnt->index, ResUnusedOpr))
>From looking at xf86SetOperatingState it appears that it returns a pointer on
success and NULL on failure. Looking at all other drivers I see that no other
driver is looking at the return value at all.
It appears what was meant was:
if (!xf86SetOperatingState(resVga, info->pEnt->index, ResUnusedOpr))
Or. perhaps the intention was to not check the return value at all. I was
unable to find any other driver that looks at it.
This seems to resolve the issues I was seeing with the Radeon card not
initializing on ia64 running Fedora.
--
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
xorg-driver-ati mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-ati
