On Fri, 2009-02-06 at 17:04 -0200, Paulo César Pereira de Andrade wrote: > Michel Dänzer wrote: > > >> I am starting to believe that, maybe -Wpointer-arith should > >> not only be out of $CWARNFLAGS, but that $CWARNFLAGS should > >> actually include -Wno-pointer-arith. > >> Almost every "casting" is a sign of something going wrong, > >> as the compiler should always able to do proper type > >> conversion automatically, > > > > I made sure the driver builds for me with -Wall a while ago, and have > > been building with -Wall -Werror since. I'm not sure I like the idea of > > enabling even more warnings, especially as apparently none of them have > > pointed out a real bug? > > It still has a significant amount of function calls without > a prototype, what can be a problem if wrong parameters are > passed, or if there is type conversion involved. > It has several static symbols with global scope. Sometimes, > when properly using static, you find out that a lot of code > or data is not used, or should be under a "#ifdef feature". > There are also too many prototypes for external functions > in C files. This can lead to problems, of declaration and > definition not matching; well, I found like 2 or 3 such cases > in previous analysis of most of Xorg packages sources...
Okay, but I'd like to see actual examples of such fixes first. > >> and changing the void *'s in the ati driver to something like an > >> "unsigned char *" just to correct that warning may not be the proper > >> solution. > > > > Are you referring to arithmetic on void* pointers? That's a gccism, so > > if we have that we may want to fix it. > > I think the solution is to ignore those warnings, otherwise, > changing the type will just trade one warning for others, and > start require using a lot of casts... What warnings are you talking about? Again, if you're talking about arithmetic on void* pointers, that'll be an error with anything but GCC (or compilers trying to be compatible with it). -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer _______________________________________________ xorg-driver-ati mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-ati
