https://bugs.freedesktop.org/show_bug.cgi?id=23144
--- Comment #9 from Da Fox <[email protected]> 2011-01-04 05:01:40 PST --- (In reply to comment #8) > (In reply to comment #6) > > Finally I noticed that there appears to be a bug with rgb32 output when > > using > > certain image widths (I'll try to find an example later). I have not yet > > been > > able to find what causes this. Any help would be appreciated. > > The below part of your patch incorrectly open-codes the RADEON_ALIGN macro for > dstPitch. Using the macro instead might work better. :) > > + case FOURCC_RGBA32: > + srcPitch = width << 2; > + dstPitch = ((dst_width << 2) + hw_align) & ~hw_align; > + break; Yes, using the RADEON_ALIGN macro indeed fixed the issue. I think that piece of code was originally from kusanagi's patch, and looked good to me. I didn't look into the RADEON_ALIGN macro or why it was not used here, I kind of assumed that there was a reason for the difference. Thanks for pointing that out so fast! I see now why that wouldn't work. I'll refrain from posting a new patch since the change is so small, and this is not the final patch. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. _______________________________________________ xorg-driver-ati mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-ati
