--- El mar 27-mar-12, Alex Deucher <[email protected]> escribió:
> De: Alex Deucher <[email protected]> > Asunto: Re: ATOM_OBJECT_HEADER content revision and > RADEONGetATOMConnectorInfoFromBIOSObject > Para: "Sebastian D´Alessandro" <[email protected]> > Cc: [email protected] > Fecha: martes, 27 de marzo de 2012, 10:24 > On Mon, Mar 26, 2012 at 8:29 PM, > Sebastian D´Alessandro > <[email protected]> > wrote: > > Hello, > > > > In atombios.h I see ATOM_OBJECT_HEADER and > ATOM_OBJECT_HEADER_V3 declared, ATOM_OBJECT_HEADER_V3 has an > extra member, usMiscObjectTableOffset, but in the rest they > are identical. > > > > In radeon_atombios.c, function: > RADEONGetATOMConnectorInfoFromBIOSObject; someone considered > that if content revision is lesser than 2 the function > should fail, but usMiscObjectTableOffset is not used there. > > > > Is ATOM_OBJECT_HEADER_V2 missing? Has > ATOM_OBJECT_HEADER more members than it should? Or "if (crev > < 2) return FALSE;" should be removed from > RADEONGetATOMConnectorInfoFromBIOSObject? > > > > The code is correct as is. Version 1.2 was the first > version of the > of the table that was actually used in production and it > uses > ATOM_OBJECT_HEADER. Older versions of the table were > never used. > Version 1.3 uses ATOM_OBJECT_HEADER_V3, but the misc object > table > isn't used so it doesn't matter which version of the struct > you use in > the driver. > > Alex > I was expecting version 1.2 to be called ATOM_OBJECT_HEADER_V2 because I thought (wrongly) that an absence of a version in the structure name would mean it be version 1.1. Thanks for clarifying that for me. > > I also asked this question in AMD developer central, > > http://devgurus.amd.com/thread/158887. > > > > Thanks. > > _______________________________________________ > > xorg-driver-ati mailing list > > [email protected] > > http://lists.x.org/mailman/listinfo/xorg-driver-ati > _______________________________________________ xorg-driver-ati mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-ati
