On Mon, Nov 12, 2012 at 01:34:02PM -0500, Alex Deucher wrote: > On Mon, Nov 12, 2012 at 12:57 PM, <[email protected]> wrote: > > From: Jerome Glisse <[email protected]> > > > > exa state that we should use the pixmap to get the width, height and > > pitch to use when setting up texture (see exa.h). This fix a rare case > > where picture->pDrawable->(width|height) > pixmap->drawable.(width|height) > > Won't this break support for solid pictures? I think we still want to > retain the pPict->pDrawable check in the texture setup, just use the > pixmap dimensions rather than the picture dimensions, e.g., > > if (pPict->pDrawable) { > tex_res.w = pPix->drawable.width; > tex_res.h = pPix->drawable.height; > repeatType = pPict->repeat ? pPict->repeatType : > RepeatNone; > } else { > tex_res.w = 1; > tex_res.h = 1; > repeatType = RepeatNormal; > } >
According to rendercheck everything was fine (ie no regression as here it seems we fails a lot of test anyway). Anyway sent v2 that keeps the special case. Cheers, Jerome _______________________________________________ xorg-driver-ati mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-ati
