https://bugs.freedesktop.org/show_bug.cgi?id=72849
Priority: medium
Bug ID: 72849
Assignee: [email protected]
Summary: first argument to drmOpen() is a no-op
QA Contact: [email protected]
Severity: normal
Classification: Unclassified
OS: FreeBSD
Reporter: [email protected]
Hardware: Other
Status: NEW
Version: unspecified
Component: Driver/Radeon
Product: xorg
Created attachment 90951
--> https://bugs.freedesktop.org/attachment.cgi?id=90951&action=edit
patch
Since the introduction of a call to drmCheckModesettingSupported() in
radeon_kernel_mode_enabled(), with abort condition if such call fails, the
first argument to drmOpen() call in radeon_open_drm_master() has become a no-op
red herring.
Such argument (a kernel module name) is supposed to result in load of specified
kernel module. However, this will never happen. The problem is that if the code
containing drmOpen() call is reached, it means that
drmCheckModesettingSupported() check has previously succeeded, which implies
the module is already loaded.
So, drmOpen() will never load a kernel module. But it gives the impression that
it will.
In order to avoid this confusion, I suggest replacing it with NULL, like
xf86-video-intel driver does:
src/intel_device.c: fd = drmOpen(NULL, id);
and then taking care of module load elsewhere (I'll submit a separate bug for
that).
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
xorg-driver-ati mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-ati
