On Tue, Feb 16, 2016 at 3:29 AM, Michel Dänzer <[email protected]> wrote: > From: jimqu <[email protected]> > > If we were asked to create a shareable pixmap, it doesn't make sense > to return a pixmap which isn't shareable. Doing so caused trouble down > the line such as a crash with older versions of glamor when trying to > use GLX pixmaps of bpp < 32 via DRI2. > > Signed-off-by: JimQu <[email protected]> > (ported from amdgpu commit 2fcb7dadd3c71cd405cbbaafc777697538ca9c29) > > Signed-off-by: Michel Dänzer <[email protected]>
For the series: Reviewed-by: Alex Deucher <[email protected]> > --- > src/radeon_glamor.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/radeon_glamor.c b/src/radeon_glamor.c > index 6a12b33..cc2b1f2 100644 > --- a/src/radeon_glamor.c > +++ b/src/radeon_glamor.c > @@ -262,7 +262,9 @@ fallback_glamor: > */ > xf86DrvMsg(scrn->scrnIndex, X_WARNING, > "Failed to create textured DRI2/PRIME pixmap."); > - return pixmap; > + > + radeon_glamor_destroy_pixmap(pixmap); > + return NullPixmap; > } > /* Create textured pixmap failed means glamor failed to > * create a texture from current BO for some reasons. We turn > -- > 2.7.0 > > _______________________________________________ > xorg-driver-ati mailing list > [email protected] > https://lists.x.org/mailman/listinfo/xorg-driver-ati _______________________________________________ xorg-driver-ati mailing list [email protected] https://lists.x.org/mailman/listinfo/xorg-driver-ati
