On 12.06.2016 18:57, Yu, Qiang wrote: > *From:* Michel Dänzer <[email protected]> > >> + /* And redirect the pixmap to the new bo (for 3D). */ >> + glamor_egl_exchange_buffers(old, pixmap); >> + amdgpu_set_pixmap_private(old, priv); > > this set the old pixmap with new priv, but the old priv is not freed.
Good catch, thanks! This is actually a pre-existing leak; I'll send another series fixing this and other related leaks later. >> + old->refcnt++; > > Why increase the refcnt of the old pixmap? Another good catch, thanks. Fixed in v2 of patch 5. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer _______________________________________________ xorg-driver-ati mailing list [email protected] https://lists.x.org/mailman/listinfo/xorg-driver-ati
