Chris,
No problem. I can fix the style you points out.
Too many patched that I need to commit this time. So need your guys to
review.
And for one point
"* You should use a short summary for the subject line, and
then a longer summary for the body of the commit message, and wrap at 80"
How to do that?
Git-send-email to which place?
Thanks,
Frank
-----Original Message-----
From: Chris Ball [mailto:[email protected]]
Sent: 2010年6月9日 12:53
To: Huang, FrankR
Cc: [email protected]
Subject: Re: [Xorg-driver-geode] Patches for rendering
Hi Frank,
It's better to e-mail patches inline rather than attached, one e-mail
per patch, so that it's easy to comment on specific parts of them.
Just some quick style points on these:
* always use spaces before open braces, e.g.:
+ }else{
becomes
+ } else {
* spaces after keywords, e.g.:
+ if(exaScratch.repeat && (!exaScratch.maskrepeat) && (exaScratch.op
== PictOpSrc)){
becomes
+ if (exaScratch.repeat && !exaScratch.maskrepeat && exaScratch.op ==
PictOpSrc) {
* wrap lines longer than 80 chars, especially comments:
+ /* For the PictOpSrc operation, we need other region to be black
out of the blend region */
becomes
+ /* For the PictOpSrc operation, we need other region to be
* black out of the blend region */
* You should use a short summary for the subject line, and then a
longer summary for the body of the commit message, and wrap at 80, e.g.:
Subject: [PATCH 7/7] Fix the PictOpOver opeartion. Progressbar,scrollbar and but
ton are displayed ok.
Convert the source format in lx_prepare_composite if it is not ARGB32 when
doing the first pass.
Add a function lx_do_composite_mask_opover to handle the PictOpOver
operation,the first pass is to
do the src*(alpha of mask), the second pass is to do the src + (1-a)*dest
becomes:
Subject: [PATCH 7/7] Fixes for PictOpOver operation.
* Progressbar, scrollbar and buttons are displayed ok.
* Convert the source format in lx_prepare_composite if it is not
ARGB32 when doing the first pass.
* Add a function lx_do_composite_mask_opover to handle the PictOpOver
operation, the first pass is to do the src*(alpha of mask), the
second pass is to do the src + (1-a)*dest
Thanks for the patches! Please could you fix the style points up and
re-send, with one e-mail per patch? git-send-email will send the
patches in this way, if you're able to use that.
- Chris.
--
Chris Ball <[email protected]>
One Laptop Per Child
_______________________________________________
Xorg-driver-geode mailing list
[email protected]
http://lists.x.org/mailman/listinfo/xorg-driver-geode
