Agree with your point. But I will adjust patch 3 note. Have you reviewed the patch 3?
Thanks, Frank -----Original Message----- From: Mart Raudsepp [mailto:mart.rauds...@artecdesign.ee] Sent: 2010?6?16? 19:00 To: Huang, FrankR Cc: xorg-driver-geode@lists.x.org Subject: Re: [Xorg-driver-geode] [PATCH 2/7] Add the maskrepeat variable On N, 2010-06-10 at 14:51 +0800, Huang, FrankR wrote: > From: Frank Huang <frankr.hu...@amd.com> > > The mask picture has the repeat attribute as the source picture repeat > attribute. Use this variable to record it for the future use I'd prefer this variable to be introduced together with the need for it in patch number 5 for it to be more clear why we are introducing it. > Signed-off-by: Frank Huang <frankr.hu...@amd.com> > --- > src/lx_exa.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/lx_exa.c b/src/lx_exa.c > index ab33124..2dd0d48 100644 > --- a/src/lx_exa.c > +++ b/src/lx_exa.c > @@ -88,6 +88,7 @@ static struct > unsigned int srcColor; > int op; > int repeat; > + int maskrepeat; > unsigned int fourBpp; > unsigned int bufferOffset; > struct exa_format_t *srcFormat; > @@ -675,6 +676,7 @@ lx_prepare_composite(int op, PicturePtr pSrc, PicturePtr > pMsk, > /* Save off the info we need (reuse the source values to save space) */ > > exaScratch.type = COMP_TYPE_MASK; > + exaScratch.maskrepeat = pMsk->repeat; > > exaScratch.srcOffset = exaGetPixmapOffset(pxMsk); > exaScratch.srcPitch = exaGetPixmapPitch(pxMsk); _______________________________________________ Xorg-driver-geode mailing list Xorg-driver-geode@lists.x.org http://lists.x.org/mailman/listinfo/xorg-driver-geode
