Hi, Mart, > > *Correct the type of LXAllocShadow from Bool to static void. > > Why shouldn't LXAllocShadow be able to return if it succeeded or failed? > As in, just return TRUE if it succeeds, and then the caller maybe > wouldn't even need to separately check for pGeode->shadowArea->offset > being set?
[Hunk.Cui] lx_crtc_shadow_allocate function call LXAllocShadow (It is responsible for allocate the Rotate memory), if pGeode->shadowArea->offset doesn't exist, it will response through xf86DrvMsg. LXAllocShadow doesn't return succeed. > > *Correct reasonless comparison between pointer and integer in line 407. > > This part looks fine, assuming pGeode->shadowArea->offset is an unsigned > integer [Hunk Cui] If the allocate failed, it will print the error message to notice. Thanks, Hunk Cui _______________________________________________ Xorg-driver-geode mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-geode
