I don't know why this patch will cause havoc to normal VGA modes. Are you sure about this? From the theory of this part code, this patch only assembles all "MODE_OK" into one "MODE_OK". And I have tried on my geode LX VGA platform using this patch. It works fine and does not affect VGA modes.
Thanks, Frank > -----Original Message----- > From: [email protected] [mailto:[email protected]] On Behalf Of > Martin-éric Racine > Sent: 2010年10月28日 18:20 > To: Huang, FrankR > Cc: Geode Mailing List > Subject: Re: [Xorg-driver-geode] [PATCH 2/2] Simplify the mode_valid > function > > This one is a major NO-NO. It wreaks serious havoc on normal VGA > modes. Reverted. > > Martin-Éric > > On Thu, Oct 28, 2010 at 10:17 AM, Huang, FrankR <[email protected]> > wrote: > > > > Signed-off-by: Frank Huang<[email protected]> > > --- > > src/lx_output.c | 31 ++----------------------------- > > 1 files changed, 2 insertions(+), 29 deletions(-) > > > > diff --git a/src/lx_output.c b/src/lx_output.c > > index cd1809b..17634d4 100644 > > --- a/src/lx_output.c > > +++ b/src/lx_output.c > > @@ -152,35 +152,8 @@ lx_output_restore(xf86OutputPtr output) > > static int > > lx_output_mode_valid(xf86OutputPtr output, DisplayModePtr pMode) > > { > > - ScrnInfoPtr pScrni = output->scrn; > > - GeodeRec *pGeode = GEODEPTR(pScrni); > > - > > - /* DCON Panel specific resolution - OLPC's one */ > > - if (pGeode->Output & OUTPUT_DCON) { > > - if (pGeode->panelMode->HDisplay == 1200 && > > - pGeode->panelMode->VDisplay == 900) > > - return MODE_OK; > > - } > > - > > - if ((pGeode->Output & OUTPUT_PANEL) && > > - gfx_is_panel_mode_supported(pGeode->panelMode->HDisplay, > > - pGeode->panelMode->VDisplay, > > - pMode->HDisplay, > > - pMode->VDisplay, > > - pScrni->bitsPerPixel) != -1) { > > - > > - return MODE_OK; > > - } > > - > > - if (gfx_is_display_mode_supported(pMode->HDisplay, > > - pMode->VDisplay, > > - pScrni->bitsPerPixel, > > - GeodeGetRefreshRate(pMode)) != -1) > { > > - return MODE_OK; > > - } > > - > > - if (pMode->type & (M_T_DRIVER | M_T_PREFERRED)) > > - return MODE_OK; > > + /* FIXME: Mode validation code should be placed here for the modes > > + * that geode can not support */ > > > > return MODE_OK; > > } > > -- > > 1.7.0.1 > > > > > > _______________________________________________ > > Xorg-driver-geode mailing list > > [email protected] > > http://lists.x.org/mailman/listinfo/xorg-driver-geode _______________________________________________ Xorg-driver-geode mailing list [email protected] http://lists.x.org/mailman/listinfo/xorg-driver-geode
