On Mon, Sep 22, 2008 at 11:30:59AM +0200, Simon Thum wrote: >> -DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop) >> +DeviceSetProperty(DeviceIntPtr dev, Atom property, XIPropertyValuePtr prop, >> + BOOL delete) >> { >> if (property == XIGetKnownProperty(XI_PROP_ENABLED)) >> { >> + if (delete) /* you're not allowed to delete any server-internal >> prop */ >> + return BadAccess; >> + > Isn't that impossible anyway? If not, how about XI_PROP_MODE?
> In general, I must admit I don't really get the scenario: Client props > don't have handlers, and server-side props can only be deleted by > in-server code, right? > So what problem does the patch solve, then? the scenario here is: xinput --delete-prop "foobar pointer" "Device Enabled" Without the handler disallowing that, a client could potentially delete properties that are "owned" by the server or a driver. Cheers, Peter _______________________________________________ xorg mailing list xorg@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/xorg