On Tue, Sep 30, 2008 at 6:06 PM, Peter Hutterer <[EMAIL PROTECTED]> wrote: > On Tue, Sep 30, 2008 at 10:54:51AM -0700, Donnie Berkholz wrote: >> > Anyone opposed to a follow-up patch to install the <drivername>.pc file? >> > If not, xorg-<drivername>.pc or just<drivername>.pc? >> >> If this is going in every driver, would it make sense as part of >> xorg-macros? Also I'm wondering whether the sdk dir should be detected from >> xorg-server instead of having a configure flag at all. > > Amended patch below. Turns out the sdk detection was already there anyway, so > this patch is shorter than the previous one. > And makes the need for macros unnecessary, since it's only one line in > configure.ac and all drivers that matter already get the sdkdir anyway. > > From 95a970ed66184aff5b89434e00ca8c012c54d377 Mon Sep 17 00:00:00 2001 > From: Peter Hutterer <[EMAIL PROTECTED]> > Date: Fri, 26 Sep 2008 10:42:05 +0930 > Subject: [PATCH] Install xorg-evdev.pc for clients who need evdev-properties.h > > --- > .gitignore | 1 + > Makefile.am | 7 +++++-- > configure.ac | 7 ++++++- > include/Makefile.am | 2 ++ > xorg-evdev.pc.in | 7 +++++++ > 5 files changed, 21 insertions(+), 3 deletions(-) > create mode 100644 include/Makefile.am > create mode 100644 xorg-evdev.pc.in > > diff --git a/.gitignore b/.gitignore > index 38eebd9..78a4243 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -24,3 +24,4 @@ missing > stamp-h1 > *.bz2 > *.gz > +*.pc > diff --git a/Makefile.am b/Makefile.am > index 11064e0..140aab1 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -19,9 +19,12 @@ > # CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > AUTOMAKE_OPTIONS = foreign > -SUBDIRS = src man > +SUBDIRS = src man include > > -EXTRA_DIST = ChangeLog autogen.sh > +pkgconfigdir = $(libdir)/pkgconfig > +pkgconfig_DATA = xorg-evdev.pc > + > +EXTRA_DIST = ChangeLog autogen.sh xorg-evdev.pc.in
Total nitpicking, but it's not necessary to add xorg-evdev.pc.in to EXTRA_DIST since you added it to AC_OUTPUT in configure.ac. automake takes into account files necessary for autoconf and adds them to DIST_COMMON. -- Dan _______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
