FTR, the replacement of 8 spaces with a tab in indentation is one of my biggest pet-peeves in poor coding etiquette. Either use a tab consistently to denote one level of indentation and have people setup their editor to "display" tabs differently, or force spaces and /bop people over the head when they have a tab in leading whitespace.

This "mix" that some of the code currently employs just makes my editor wonkey because it treats the tabs as 4-spaces because of my 4- space-indentation setting (yes, I could probably change my editor settings, but I don't want to, and I shouldn't have to)...

On Nov 19, 2008, at 10:46, Adam Jackson wrote:

On Wed, 2008-11-19 at 09:57 -0800, Dan Nicholson wrote:
Sorry for the bikeshed question, but I'm confused by what style I
should be using when patching the server. It seems that the consensus
is 4-space indentation, and that's fine. But I keep seeing that when
the opening indentation is at least 8, real tabs are used to fill as
much as possible. Is that the intention? If not, should I keep that
style when patching into code that does? I don't care what style is
used.

Really, this is the sort of thing we should just enforce in a commit
hook.  At which point it doesn't matter what your editor does.

- ajax
_______________________________________________
xorg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xorg

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
xorg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xorg

Reply via email to