On Mon, Dec 01, 2008 at 03:24:42PM +1000, Peter Hutterer wrote: > On Wed, Nov 26, 2008 at 06:28:58AM -0800, Dan Nicholson wrote: > > So, it turns out that XkbCopyKeymap doesn't quite do what you'd expect, > > failing to copy a few fields of the XkbDescRec. I'm not sure whether it's > > appropriate to copy .device_spec from the cached keymap, but it didn't > > seem to hurt in my testing. > > Tbh, I don't know either :) Daniel, any insights?
I'm not sure why device_spec even _exists_ (except to be able to pass an XkbSrvInfoPtr instead of a DeviceIntPtr, but honestly, what's the point in doing that: just pass either a DeviceIntPtr or an XkbDescPtr), so that's on my xkb-atkins hitlist (ha!). defined should almost certainly be copied, yeah. > I tried to reproduce the issue I pointed out with the last revision and it > looks like the VCK doesn't switch keymaps properly anyway. That needs to be > fixed, but it's not caused by your patch. Hmm. Are we just not sending the appropriate notifications? (i.e. does it work with p.fd.o/~daniels/xserver.git:xkb-atkins?) Cheers, Daniel
signature.asc
Description: Digital signature
_______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
