Peter Breitenlohner wrote:
> Hi,
>
> in your recent commit 9ff834493ece0a0ea7d7f15c1706bab022362cc5 you have
> removed two warning flags for gcc < 4.
>
> Looking at older gcc versions I just saw that both flags were absent in
> gcc-3.3.x, but present in gcc-3.4.x.
>
> These flags are eminently useful to find places that need conversion to
> ANSI
> C. Thus, please modify the test such that they are included for gcc >=
> 3.4.
>
The attached patch works for me on gcc 3.3 and 4.2. Can you confirm that
gcc 3.4 now uses the full flags again too, before I commit it?
--
Matthieu Herrb
diff --git a/xorg-macros.m4.in b/xorg-macros.m4.in
index 9a2e26a..cbdcfa6 100644
--- a/xorg-macros.m4.in
+++ b/xorg-macros.m4.in
@@ -446,7 +446,7 @@ if test "x$GCC" = xyes ; then
-Wmissing-declarations -Wnested-externs -fno-strict-aliasing \
-Wbad-function-cast"
case `gcc -dumpversion` in
- 4.*)
+ 3.4.* | 4.*)
CWARNFLAGS+=" -Wold-style-definition -Wdeclaration-after-statement"
;;
esac
_______________________________________________
xorg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xorg
