I don't know if anyone's still using this hardware. My main motivation here is to make sure that drivers implement the various repeat modes in exa's composite operation correctly (that is, fall back to software if they don't), so that cairo's performance-crippling client-side fallback for EXTEND_PAD can hopefully disabled someday. It'd be nice if someone with git access could commit this patch.
Thanks, Tom
>From e2536dac06d82f2d2a2b77d8d00fc85925889d81 Mon Sep 17 00:00:00 2001 From: Thomas Jaeger <[email protected]> Date: Fri, 30 Jan 2009 16:25:07 -0500 Subject: [PATCH] CheckComposite: Add a few checks It looks like the driver doesn't support any form of repeating and only nearest-neighbor interpolation. --- src/i128exa.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/src/i128exa.c b/src/i128exa.c index 84452a8..5bf0c5d 100644 --- a/src/i128exa.c +++ b/src/i128exa.c @@ -476,11 +476,15 @@ i128CheckComposite(int op, PicturePtr pSrcPicture, PicturePtr pMaskPicture, if (pMaskPicture) return FALSE; /* when transforms added, be sure to check for linear/nearest */ - /* if (pSrcPicture->transform) return FALSE; */ + if (pSrcPicture->transform && pSrcPicture->filter != PictFilterNearest) + return FALSE; /* no support for external alpha */ if (pSrcPicture->alphaMap || pDstPicture->alphaMap) return FALSE; + /* no support for repeating */ + if (pSrcPicture->repeat) return FALSE; + pI128->source = i128MapSourceFormat(pSrcPicture->format); if (!pI128->source) return FALSE; -- 1.6.0.6
_______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
