Peter Hutterer wrote: > I think it'd be better to call XkbGetRulesDflts(&g_winInfo.xkb);
>> + memset(&rmlvo, 0, sizeof(rmlvo)); > > arguably superfluous, since you set everything anyway. Good point. I'd failed to make g_winInfo.xkb a XkbRMLVOSet which fixes both your comments. Thanks for taking the time to review my patch. > Rest looks OK. > > btw. do you have a fdo account or do you need someone to push it? If the > latter, please tell me (and make sure you CC me on the email). I have a fdo account, so I've pushed this patch with that improvement. (commit 4475ae036c3d5a06a6ce88a359ce2a9a8ae9b4f1) _______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
