On Tue, Feb 3, 2009 at 4:51 PM, Peter Hutterer <[email protected]> wrote: > On Tue, Feb 03, 2009 at 04:46:05PM -0800, Dan Nicholson wrote: >> On Tue, Feb 3, 2009 at 4:30 PM, Peter Hutterer <[email protected]> >> wrote: >> > If we have a busted xkb setup, the XKB initialization on the core devices >> > fails and leaves us with dev->key->xkbInfo == NULL. This in turn causes >> > segfaults lateron. >> > >> > Return BadValue when the XKB configuration for a master device failed, and >> > if >> > that happens for the VCP/VCK, die semi-gracefully. >> >> Seems reasonable to me. I'd much rather die early than scratch my head >> on some later crash. Would it also be a good idea to return BadValue >> from CorePointerProc when InitPointerDeviceStruct fails? I don't know >> what you'd put in the log in that situation, though. > > IPDS seems to only fail if we run out of memory. What about adding hunk 2?
Yeah, looks like it. Acked-by: Dan Nicholson <[email protected]> -- Dan _______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
