On 02/04/2009 10:57 PM, Ian Romanick wrote:
On Wed, Feb 04, 2009 at 12:02:24AM +0100, Tomas Carnecky wrote:
Add parenthesis around the whole expression.

Signed-off-by: Tomas Carnecky<[email protected]>
---
  glx/indirect_dispatch.c      |    2 +-
  glx/indirect_dispatch_swap.c |    2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

NAK.  These source files are program generated.  Didn't you see the
big comment at the top of the file?

/* DO NOT EDIT - This file generated automatically by glX_proto_recv.py (from 
Mesa) script */

Make the correction to the generator script.  Otherwise, the changes
will be lost the next time the generator script is run.

Oops. I saw that header in glapitemp.h, but not in these file. Patch to the script is attached.

tom
From 324eccc2d9f43025b3638b3ecf4613a5050f725f Mon Sep 17 00:00:00 2001
From: Tomas Carnecky <[email protected]>
Date: Wed, 4 Feb 2009 23:31:54 +0100
Subject: [PATCH] Fix "cast to pointer from integer of different size"

Add parenthesis around the whole expression.

Signed-off-by: Tomas Carnecky <[email protected]>
---
 src/mesa/glapi/glX_proto_recv.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/mesa/glapi/glX_proto_recv.py b/src/mesa/glapi/glX_proto_recv.py
index 923c195..f423c6d 100644
--- a/src/mesa/glapi/glX_proto_recv.py
+++ b/src/mesa/glapi/glX_proto_recv.py
@@ -277,7 +277,7 @@ class 
PrintGlxDispatchFunctions(glX_proto_common.glx_print_proto):
                        if param.is_image():
                                offset = f.offset_of( param.name )
 
-                               print '%s    %s const %s = (%s) %s(pc + %s);' % 
(indent, type_string, param.name, type_string, cond, offset)
+                               print '%s    %s const %s = (%s) (%s(pc + %s));' 
% (indent, type_string, param.name, type_string, cond, offset)
                                
                                if param.depth:
                                        print '%s    __GLXpixel3DHeader * const 
hdr = (__GLXpixel3DHeader *)(pc);' % (indent)
-- 
1.6.1.2

_______________________________________________
xorg mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/xorg

Reply via email to