On Fri, 2009-11-13 at 16:57 +0800, walter harms wrote: > > ykzhao schrieb: > > On Fri, 2009-11-13 at 09:34 +0800, Zhao, Yakui wrote: > >> From: Zhao Yakui <[email protected]> > >> > >> Move the EDID quirk for Philips LCD LP154W01 as the panel reports the > >> vertical > >> size in cm. > > Hi, Ajax > > The EDID in several Philips LCD monitor reports the panel vertical > > size in cm, which causes that the user gets the incorrect DPI. So we > > should add the EDID quirk for such display monitors. > > > > In fact we also have the edid quirk for these display monitors. But > > it is put into the wrong place. > > > > Do you have an opportunity to look at this patch? > > > > Thanks. > > > > > >> https://bugs.freedesktop.org/show_bug.cgi?id=24482 > >> > >> Signed-off-by: Zhao Yakui <[email protected]> > >> --- > >> hw/xfree86/modes/xf86EdidModes.c | 10 ++++------ > >> 1 files changed, 4 insertions(+), 6 deletions(-) > >> > >> diff --git a/hw/xfree86/modes/xf86EdidModes.c > >> b/hw/xfree86/modes/xf86EdidModes.c > >> index 449078e..356e51e 100644 > >> --- a/hw/xfree86/modes/xf86EdidModes.c > >> +++ b/hw/xfree86/modes/xf86EdidModes.c > >> @@ -131,8 +131,11 @@ static Bool quirk_detailed_v_in_cm (int scrnIndex, > >> xf86MonPtr DDC) > >> return TRUE; > >> > >> /* Bug #21000: LGPhilipsLCD LP154W01-TLAJ */ > >> + /* Bug #10304: LGPhilipsLCD LP154W01-A5 */ > >> if (memcmp (DDC->vendor.name, "LPL", 4) == 0 && > >> - DDC->vendor.prod_id == 47360) > >> + (DDC->vendor.prod_id == 47360 || > >> + DDC->vendor.prod_id == 0 || > >> + DDC->vendor.prod_id == 0x2a00)) > >> return TRUE; > >> > >> /* Bug #21750: Samsung Syncmaster 2333HD */ > >> @@ -145,11 +148,6 @@ static Bool quirk_detailed_v_in_cm (int scrnIndex, > >> xf86MonPtr DDC) > >> > >> static Bool quirk_detailed_use_maximum_size (int scrnIndex, xf86MonPtr > >> DDC) > >> { > >> - /* Bug #10304: LGPhilipsLCD LP154W01-A5 */ > >> - if (memcmp (DDC->vendor.name, "LPL", 4) == 0 && > >> - (DDC->vendor.prod_id == 0 || DDC->vendor.prod_id == 0x2a00)) > >> - return TRUE; > >> - > >> /* Bug #21324: Iiyama Vision Master 450 */ > >> if (memcmp (DDC->vendor.name, "IVM", 4) == 0 && > >> DDC->vendor.prod_id == 6400) > > > > > just a general question, > is it clever to do such things in code ? > IMHO something like a "blacklist" is needed so the system can bail out > on monitors that report crap. That would add the opportunity for other to > contribute. In fact the quirk is similar to the "blacklist", which is used to correct the wrong parameter reported by monitor. > > /* note i have no idea how to do this practical given the huge number of > possible bugs but certainly that would be a huge boost for the autoconfig > stuff > */ > > re, > wh
_______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
