On Sun, 24 Jan 2010 12:49:00 -0800 Keith Packard <[email protected]> wrote:
> On Thu, 21 Jan 2010 10:31:04 -0800, Eric Anholt <[email protected]> > wrote: > > > - if (!drawable->eventMask & GLX_BUFFER_SWAP_COMPLETE_INTEL_MASK) > > + if (!(drawable->eventMask & > > GLX_BUFFER_SWAP_COMPLETE_INTEL_MASK)) > > Reviewed-by: Keith Packard <[email protected]> > > I'll note that using 'drawable' as a name here is sub-optimal. Also > the code in glxcmds.c that sets eventMask has an inaccurate comment, > and also fails to validate the event mask to make sure it doesn't > include bits which aren't allowed. Oops yeah thanks for catching it. This might actually explain the kwin crash I hit after fixing a bug with drawable lifetimes... -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ xorg mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/xorg
