Hi,
The patch looks good assuming that a bad nexthop from a peer is still
handled correctly.
Atanu.
On Thu, Apr 22, 2010 at 11:25 AM, Ben Greear <[email protected]> wrote:
> On 04/22/2010 10:37 AM, Atanu Ghosh wrote:
>>
>> Hi,
>>
>> The original code caught all exceptions from bad update packets in
>> peer.cc:BGPPeer::get_message. At the bottom of this routine you can
>> see the CorruptMessage exceptions being caught and the notification
>> being sent to the peer.
>>
>> Your stack backtrace looks like the current code does not check the
>> update packet for sanity but just queues it, then later when the
>> packet is being processed it notices a problem and throws an
>> exception, which is not caught. Temporarily you could try catching the
>> exceptions around pull_next_route in the RibOutTable.
>
> How does the attached patch look to you? It seems to fix
> the problem for me...
>
> Thanks,
> Ben
>
> --
> Ben Greear <[email protected]>
> Candela Technologies Inc http://www.candelatech.com
>
>
_______________________________________________
Xorp-hackers mailing list
[email protected]
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
