On 09/13/2011 11:59 AM, Ben Greear wrote: > On 09/13/2011 11:33 AM, Steven Simpson wrote: >> On 13/09/11 19:28, Steven Simpson wrote: >>>>> libcomm/comm_sock.c:302:28: note: each undeclared identifier is >>>>> reported only once for each function it appears in >>>>> libcomm/comm_sock.c:302:35: error: expected ';' before 'family' >>>>> libcomm/comm_sock.c: In function 'comm_sock_bind6': >>>>> libcomm/comm_sock.c:342:30: error: 'u_char' undeclared (first use in >>>>> this function) >>> Tried with -std=gnu89? >> >> Err, gnu99. > > -std=gnu99 with the typo fix compiles. If we have to, we can conditionally > enabled -std=gnu99 for systems that require it, with some sort of scons > logic to figure out when it's needed. > > Still, if you have a fix that doesn't require any -std=foo options, I think > that > is probably preferable..
I pushed a fix that conditionally uses -std=gnu99, looks good so far. But, wouldn't mind backing that out if you have a different cure that requires no compiler flags. Thanks, Ben > > Thanks, > Ben > >> >> _______________________________________________ >> Xorp-hackers mailing list >> [email protected] >> http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers > > -- Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ Xorp-hackers mailing list [email protected] http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
