Branch: refs/heads/master
  Home:   https://github.com/greearb/xorp.ct

  Commit: e341d699bb57e3e3d7d66f1bb9ff30461e733410
      
https://github.com/greearb/xorp.ct/commit/e341d699bb57e3e3d7d66f1bb9ff30461e733410
  Author: Ben Greear <[email protected]>
  Date:   2011-09-16 (Fri, 16 Sep 2011)

  Changed paths:
    M xorp/pim/pim_mfc.cc
  M xorp/pim/pim_mfc.hh
  M xorp/pim/pim_mre.cc
  M xorp/pim/pim_mre.hh
  M xorp/pim/pim_mre_assert.cc
  M xorp/pim/pim_mre_data.cc
  M xorp/pim/pim_mre_join_prune.cc
  M xorp/pim/pim_mre_register.cc
  M xorp/pim/pim_mre_rpf.cc
  M xorp/pim/pim_mre_task.cc
  M xorp/pim/pim_mre_task.hh
  M xorp/pim/pim_mre_track_state.cc
  M xorp/pim/pim_mre_track_state.hh
  M xorp/pim/pim_mrt.cc
  M xorp/pim/pim_mrt.hh
  M xorp/pim/pim_mrt_mfc.cc
  M xorp/pim/pim_mrt_task.cc
  M xorp/pim/pim_node.cc
  M xorp/pim/pim_node.hh

  Log Message:
  -----------
  pim:  Use pointers instead of references for members.

pim has a nasty bug that causes pure virtual functions to
be called during some destructors.  This is probably due to
the tangle of class references held in various structs.

I believe the way to clean this up is to use pointers and
then carefully null them out on teardown and add appropriate
checks for null in the destruct sequences.

This patch should make no functional change..just change to
using pointers.

Signed-off-by: Ben Greear <[email protected]>


  Commit: aa3da4a90f3dc351760c8c9fb946e27570d759f5
      
https://github.com/greearb/xorp.ct/commit/aa3da4a90f3dc351760c8c9fb946e27570d759f5
  Author: Ben Greear <[email protected]>
  Date:   2011-09-16 (Fri, 16 Sep 2011)

  Changed paths:
    M xorp/pim/pim_node.cc
  M xorp/pim/pim_node.hh
  M xorp/pim/xorp_pimsm4.cc
  M xorp/pim/xorp_pimsm6.cc
  M xorp/pim/xrl_pim_node.cc
  M xorp/pim/xrl_pim_node.hh

  Log Message:
  -----------
  pim:  Attempt manual destruction of pim node.

This might work around the pure-virtual call.  Needs
testing and running under valgrind, however.

Signed-off-by: Ben Greear <[email protected]>


Compare: https://github.com/greearb/xorp.ct/compare/1e84c22...aa3da4a

_______________________________________________
Xorp-hackers mailing list
[email protected]
http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers

Reply via email to