On 09/27/2011 04:29 AM, Igor Maravic wrote: > Patch for smart script! It checks if adduser supports --system and > --no-create-home. > Checking for -M option could be added, but I don't have fedora to test it. > I'm running Ubuntu 11.04 with kernel 2.6.38.8
I applied everything but the optimize SConstruct patch. It still needs work in my opinion. Your patches applied fine, but you need to add useful commit messages for each patch. The patch 0/X email never actually gets into git, it is just for humans to read. The comments you put in the 0/X emails are fine, but you need to add the comments for the individual patches as well. I fixed the commit messages this time, but please make sure you have good commit messages for future patches. Thanks, Ben -- Ben Greear <[email protected]> Candela Technologies Inc http://www.candelatech.com _______________________________________________ Xorp-hackers mailing list [email protected] http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
