Hi!
> The fixed-up patch has been applied and will be pushed shortly. > I also fixed up the title and comments. Thank You! > Thanks, No problem :-) > It [Var_D] still did not apply with 'git am'. - {-- XLOG_ASSERT ^^^ may be "--" in Subj ( see "diff of patches" later) go to strange work "git am" { > I had to edit it to remove the character in front of 'From' at the beginning > of the patch. see "diff of patches" later : "character in front of 'From'" simply not exit ;-0 == Well fun..looks like my email client (firefox) screws up the attachment as well, by prepending a > in front of 'From'. == Ok -- not only my e-mail client work strange :-) } > See the attached patch as an example of what I consider good > title and comment section for a patch. Ok "diff of patches": == --- Var_D_0002-FEA-fibconfig_entry_set_rtmv2.cc-delete_entry-XLOG_W.patch Wed Mar 21 18:56:03 2012 +++ xorp-fib.patch Wed Mar 21 19:19:30 2012 @@ -1,8 +1,10 @@ From fad792992b2edc3896808250835445d7a124160a Mon Sep 17 00:00:00 2001 From: Victor Miasnikov <v...@tut.by> Date: Wed, 21 Mar 2012 18:53:41 +0300 -Subject: [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING - {-- XLOG_ASSERT +Subject: [PATCH] FEA/rtmv2: Fix XLOG_ASSERT if vifp is not found. + +There is no need to assert if we try to remove something that +is already gone. Signed-off-by: Victor Miasnikov <v...@tut.by> --- == Best regards, Victor Miasnikov Blog: http://vvm.blog.tut.by/ ----- Original Message ----- From: "Ben Greear" <gree...@candelatech.com> To: "Victor Miasnikov" <v...@tut.by> Cc: <xorp-hackers@icir.org> Sent: Wednesday, March 21, 2012 7:14 PM Subject: Re: [PATCH] FEA fibconfig_entry_set_rtmv2.cc delete_entry XLOG_WARNING {-- XLOG_ASSERT(vifp != NULL); > > It still did not apply with 'git am'. I had to edit it to remove the > character in front of 'From' at the beginning of the patch. > > I also fixed up the title and comments. > > See the attached patch as an example of what I consider good > title and comment section for a patch. > > The fixed-up patch has been applied and will be pushed shortly. > > Thanks, > Ben > > -- > Ben Greear <gree...@candelatech.com> > Candela Technologies Inc http://www.candelatech.com _______________________________________________ Xorp-hackers mailing list Xorp-hackers@icir.org http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers