Hey Ben, Yeah I got it working with OSPF and RIP in CORE, I didn't include OSPF just for simplicity.
Thanks, JM On Thu, Jan 10, 2013 at 12:19 PM, Ben Greear <[email protected]>wrote: > On 01/10/2013 09:13 AM, Jean Michel MacKay wrote: > >> Hey, >> I realize now that I might of sent this patch at a bad time (right before >> the holidays). I was just wondering if anyone had time or will have time to >> look at it. >> >> Here is a little description: >> >> This patch allows admin distances to be changed through the config file. >> >> I've mapped the token 'distance', currently only in RIP (also works for >> OSPF), to the RIB's set_protocol_admin_distance. Now the origin table is >> already created >> once set_protocol_admin_distance is called, so it fails. I assume that it >> fails because you shouldn't change the AD once the origin table exists, >> since it >> would comprise all the merge tables using that origin table. >> >> How I got around this was to implement change_admin_distance in the class >> OriginTable and only allow the AD to be changed if they are no routes in the >> OriginTable. Since that should keep the integrity of the merge tables. >> >> Does this sound right? I'm worried that I'm missing something about the >> design of the RIB. >> > > The patch looks harmless enough to me. You've tested it and it works > for you? > > Thanks, > Ben > > -- > Ben Greear <[email protected]> > Candela Technologies Inc http://www.candelatech.com > >
_______________________________________________ Xorp-hackers mailing list [email protected] http://mailman.ICSI.Berkeley.EDU/mailman/listinfo/xorp-hackers
