Dear Timo, Thanks for the patch. This seems like a very useful improvement on the original patch by aiwarrior.
I'm still having mixed feelings about the threaded version -- it seems difficult to make sure everything's completely thread-safe, and auto-save should be a 100% reliable feature. (I still haven't had a chance to read carefully aiwarrior's multi-threaded patch; I don't mean to doubt its overall reliability, it's simply that multi-threaded is really a whole lot more complex than single-thread). At some point (I'm afraid I can't really make any concrete promises given my history of getting far behind schedule) I'll want to review all the auto-save patches and incorporate what I think works best. So, anyway, unless you're feeling particularly motivated, I think it's fine to keep your patch in its current version (not using threads). Thanks again, Best, Denis On 11/30/2010 12:09 PM, Timo Kluck wrote: > Dear Xournal-developers, > > I would be very grateful for your opinions about a patch I made for > the autosave option. > > I based my work on this older patch by aiwarrior: > http://sourceforge.net/tracker/?func=detail&aid=2881919&group_id=163434&atid=827735 > > I had not noticed that aiwarrior had posted a more recent patch that > does autosave in a separate thread. Still, some of my aditions may be > useful. My work takes care of the following (copied from the patch > description): > > Autosaves are now stored "along side" the .xoj file, with a > .xoj.autosave~ suffix. If the file has no filename yet, an autosave is > made in the user's homedir. Additionally, a table of all running > xournal instances, together with their autosave filenames, is > maintained in ~/.xournal/autosaves. On startup, xournal checks if any > of these table entries have been 'orphaned' and prompts the user > before restoring. > Furthermore, when opening a file, xournal checks if there exists a > corresponding .autosave~ file, and restores it if it is newer. > > I haven't studied aiwarrior's latest patch yet, but will do so. In the > mean time: I am curious about your reviews of my patch. Also, could > you comment on whether it is useful for aiwarrior's patch and mine to > be adapted to one another? > > Best regards, > > Timo Kluck > > PS I am the same guy who made some UI suggestions a while ago; I am > working on implementing these so that their merits / shortcomings can > be judged. > > PPS I am not on the xournal-devel mailinglist - could you also reply > to my e-mail address tkl...@gmail.com > -- Denis Auroux aur...@math.mit.edu MIT Department of Mathematics ON LEAVE AT UC BERKELEY 77 Massachusetts Ave. 2-236 Cambridge MA 02139 ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Xournal-devel mailing list Xournal-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/xournal-devel
